drossos commented on code in PR #1049:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/1049#discussion_r2743111286
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/utils/bluegreen/BlueGreenUtils.java:
##########
@@ -350,6 +351,13 @@ public static FlinkDeployment prepareFlinkDeployment(
flinkDeployment.setSpec(spec.getTemplate().getSpec());
+ // Update Ingress template if exists to prevent path collision between
Blue and Green
+ IngressSpec ingress = flinkDeployment.getSpec().getIngress();
+ if (ingress != null) {
+ ingress.setTemplate(
+ blueGreenDeploymentType.name().toLowerCase() + "-" +
ingress.getTemplate());
+ }
Review Comment:
In our case, some teams have a long blue-green parallel running period and
being able to still have access both UIs can be useful for monitoring and
comparing during this time.
Since the BG ingress is distinct from the child ingresses, user could just
specify the BG ingress in their spec and exclude the Flinkdeployment level
ingress to get the behaviour of a singular rotating ingress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
