gaborgsomogyi commented on code in PR #27491:
URL: https://github.com/apache/flink/pull/27491#discussion_r2743319150
##########
flink-runtime/src/test/java/org/apache/flink/runtime/blob/BlobClientSslTest.java:
##########
@@ -52,6 +52,9 @@ static void startSSLServer() throws IOException {
Configuration config =
SSLUtilsTest.createInternalSslConfigWithKeyAndTrustStores(
SecurityOptions.SSL_PROVIDER.defaultValue());
+ config.set(
+ SecurityOptions.SSL_ALGORITHMS,
+
"TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256,TLS_RSA_WITH_AES_128_GCM_SHA256,TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256");
Review Comment:
I think `ECDSA` is never ever tested because it became stable in java11 and
not seen any effort so we can use the 2 `RSA` configs.
##########
flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobUtils.java:
##########
@@ -60,7 +60,7 @@
public class BlobUtils {
/** Algorithm to be used for calculating the BLOB keys. */
- private static final String HASHING_ALGORITHM = "SHA-1";
+ private static final String HASHING_ALGORITHM = "SHA-256";
Review Comment:
Not yet understand why this needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
