davidradl commented on code in PR #27491:
URL: https://github.com/apache/flink/pull/27491#discussion_r2746972744
##########
flink-runtime/src/test/java/org/apache/flink/runtime/net/SSLUtilsTest.java:
##########
@@ -367,7 +367,7 @@ void
testSetSSLVersionAndCipherSuitesForSSLServerSocket(String sslProvider) thro
serverConfig.set(SecurityOptions.SSL_PROTOCOL, "TLSv1.1");
serverConfig.set(
SecurityOptions.SSL_ALGORITHMS,
-
"TLS_RSA_WITH_AES_128_CBC_SHA,TLS_RSA_WITH_AES_128_CBC_SHA256");
+
"TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256,TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384");
Review Comment:
I am not an expert, from a quick google it mentioned that there are high
compatibility alternatives if we need to support older clients that do not
support GCM. Like TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA instead of
TLS_RSA_WITH_AES_128_CBC_SHA.
For Flink do we need to support older clients that do not support GCM? If so
maybe we should use those libraries in our test suites.
I suspect as you have it is correct, but wanted to raise this consideration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
