xintongsong commented on code in PR #510:
URL: https://github.com/apache/flink-agents/pull/510#discussion_r2750377150
##########
runtime/src/test/java/org/apache/flink/agents/runtime/python/event/PythonEventTest.java:
##########
@@ -117,7 +117,7 @@ void testEventLogRecordSerializationWithEventJsonStr()
throws Exception {
JsonNode eventNode = jsonNode.get("event");
assertThat(eventNode.get("eventType").asText()).isEqualTo(eventType);
assertThat(eventNode.get("id").asText()).isEqualTo(eventId.toString());
- // Byte array should not be in the log
- assertThat(eventNode.has("event")).isFalse();
+ // Byte array should be serialized for ActionState persistence
+ assertThat(eventNode.has("event")).isTrue();
Review Comment:
This test case should not be changed. It verified the serialization for
event logs, rather than for action states. It's expected not changed. This is
the cause of the CI failures.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
