stoiev commented on PR #27450: URL: https://github.com/apache/flink/pull/27450#issuecomment-3830922855
> > @stoiev I am curious are there scenarios where the old URL can and should be used ? A change like this will break all users of the old URL. I was thinking that you would tolerate multiple endpoints, maybe by indicating in Flink config what type of connection is required then the Flink code can use the appropriate URL. > > The change to `api.` over `app.` was [way back in 2018](https://github.com/DataDog/datadogpy/pull/258), and afaik the `app.` is just a subdomain for the front-end part of the platform in each DC. > > So from that perspective, this shouldn't cause any issues in terms of backwards incompatibility (Don't quote me tho, I'm customer-facing Datadog eng, but I'll seeing if I can double check with someone on the platform team on that front), > > Technically I guess it's a "breaking change" if someone's specifically whitelisted `app` for Splink and then they get changed by this... > > PS. Sorry to barge into another PR, I'm just in the same boat helping a customer with some similar DC config issues, as well as seeing if I can show some love to some of the older docs and setup for Datadog parts of Flink 👍🏻 Thanks @petems! You got the point: It's hard to say that this won't break anything anywhere. In edge cases, users restrict network based in domains. But since protocol is the same, there would be no effect in datadog - flink integration where network works. Even with a configuration variable, I would argue to shift default to `api.datadoghq`, since it's the only API domain supported and publicized on documentation. Also, there is already a [PR](https://github.com/apache/flink/pull/25592) to create this configuration. I just created this new one thinking that would be easier to ship just the URL change on Flink's code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
