davidradl commented on code in PR #46:
URL: 
https://github.com/apache/flink-connector-shared-utils/pull/46#discussion_r2753434876


##########
.github/workflows/ci.yml:
##########
@@ -158,7 +158,7 @@ jobs:
         run: wget -q -c ${{ env.binary_url }} -O - | tar -xz
 
       - name: Cache Flink binary
-        if: ${{ env.cache_binary == 'true' }}
+        if: steps.restore-cache-flink.outputs.cache-hit != 'true'

Review Comment:
   We should do `${{ env.cache_binary == 'true' }} `as well - so we only do 
caching processing if caching is specified? i.e. `and `these to conditions with 
`${{ env.cache_binary == 'true' }} `first .



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to