davidradl commented on code in PR #27499:
URL: https://github.com/apache/flink/pull/27499#discussion_r2753505778
##########
flink-formats/flink-avro/src/main/java/org/apache/flink/formats/avro/AvroDeserializationSchema.java:
##########
@@ -188,7 +248,17 @@ void checkAvroInitialized() throws IOException {
if (datumReader != null) {
return;
}
-
+ synchronized (this) {
+ if (isFastReaderEnabled()) {
+ String openFlag = System.getProperty(FAST_READER_PROP);
+ if (StringUtils.isEmpty(openFlag)) {
+ System.setProperty(FAST_READER_PROP, "true");
+ LOG.info(
+ "{} are enabled, but FAST_READER_PROP is empty. We
just change it to true.",
Review Comment:
I find this message confusing. `if FAST_READER_PROP is empty,` the test
implies the code changes the system property to true. what does this mean?
##########
flink-formats/flink-avro/src/main/java/org/apache/flink/formats/avro/AvroDeserializationSchema.java:
##########
@@ -188,7 +248,17 @@ void checkAvroInitialized() throws IOException {
if (datumReader != null) {
return;
}
-
+ synchronized (this) {
Review Comment:
why is this synchronized?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
