sa-kononov opened a new pull request, #27501: URL: https://github.com/apache/flink/pull/27501
## What is the purpose of the change This pull request fixes a bug in checking which watermark can fire a window in WindowAggregate operator. An optimization with this check was introduced in #15495 with the function [TimeWindowUtils.getNextTriggerWatermark()](https://github.com/apache/flink/blob/80e26ca982872b2eae6266816ccfd6007de17b08/flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/util/TimeWindowUtil.java#L186) that did not account for windows with a non-zero offset. As the result it leaded to dropping all but the last window events from cascaded (double) WindowAggregate. ## Brief change log - an offset parameter is added to TimeWindowUtils.getNextTriggerWatermark() and the function is renamed for clarity - window offset for this is now provided by SliceAssigner interface and its implementations ## Verifying this change Please make sure both new and modified tests in this PR follow [the conventions for tests defined in our code quality guide](https://flink.apache.org/how-to-contribute/code-style-and-quality-common/#7-testing). This change added tests and can be verified as follows: - WindowAggregateITCase.testCascadeEventTimeTumbleWindowWithOffset() is modified to cover the relevant case (no need to introduce a new test) ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): no - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no - The serializers: no - The runtime per-record code paths (performance sensitive): don't know - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no - The S3 file system connector: no ## Documentation - Does this pull request introduce a new feature? no - If yes, how is the feature documented? not applicable -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
