Savonitar commented on code in PR #219:
URL:
https://github.com/apache/flink-connector-kafka/pull/219#discussion_r2758284565
##########
flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/testutils/TestKafkaContainer.java:
##########
@@ -77,7 +80,8 @@ public TestKafkaContainer(DockerImageName dockerImageName) {
.withEnv(
"KAFKA_LISTENER_SECURITY_PROTOCOL_MAP",
"PLAINTEXT:PLAINTEXT,BROKER:PLAINTEXT,CONTROLLER:PLAINTEXT")
- .withEnv("KAFKA_INTER_BROKER_LISTENER_NAME",
"BROKER");
+ .withEnv("KAFKA_INTER_BROKER_LISTENER_NAME",
"BROKER")
+
.waitingFor(Wait.forSuccessfulCommand(CONTAINER_STARTUP_CHECK).withStartupTimeout(CONTAINER_STARTUP_TIMEOUT));
Review Comment:
Doesn't `ConfluentKafkaContainer` already have and use a wait strategy
inside?
it has a wait strategy
in
org.testcontainers.kafka.ConfluentKafkaContainer#ConfluentKafkaContainer(org.testcontainers.utility.DockerImageName)
```
this.waitingFor(KafkaHelper.WAIT_STRATEGY);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
