wenjin272 commented on PR #514: URL: https://github.com/apache/flink-agents/pull/514#issuecomment-3845096948
Hi, @klaudworks, thanks for your detailed bug report and fix. Since you only verified with custom resource, I verify the fix with custom event. It works well. The fix looks good to me. Additionally, I investigated when we set the TCCL to the UserCodeClassLoader. 1. For agent plan deserialization, the `UserCodeClassLoader` is set by `UserDefinedObjectsHolder` in Flink `StreamGraph`. 2. For resource creation, the `UserCodeClassLoader` is set in `JavaActionTask` before execute action. 3. For event log deserialization, there is no place to set the `UserCodeClassLoader` because deserialization does not actually occur. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
