yuxiqian commented on code in PR #4253:
URL: https://github.com/apache/flink-cdc/pull/4253#discussion_r2752581409
##########
flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-starrocks/src/main/java/org/apache/flink/cdc/connectors/starrocks/sink/StarRocksUtils.java:
##########
@@ -183,6 +184,9 @@ record ->
fieldGetter =
record ->
record.getDate(fieldPos).toLocalDate().format(DATE_FORMATTER);
break;
+ case TIME_WITHOUT_TIME_ZONE:
+ fieldGetter = record ->
record.getTime(fieldPos).toLocalTime().toString();
Review Comment:
I remember that formatting `LocalTime`s on the hour, like `LocalTime.of(16,
0, 0).toString()` will yield `16:00` without seconds part, which may break the
assumptions on the length of result string. Shall we provide `TIME_FORMATTER`s
for `TIME` in different precisions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
