lihaosky commented on code in PR #27394:
URL: https://github.com/apache/flink/pull/27394#discussion_r2766694362
##########
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/TableEnvironmentImpl.java:
##########
@@ -263,6 +265,19 @@ public static TableEnvironmentImpl
create(EnvironmentSettings settings) {
? settings.getCatalogStore()
: catalogStoreFactory.createCatalogStore();
+ final SecretStoreFactory secretStoreFactory =
+ TableFactoryUtil.findAndCreateSecretStoreFactory(
+ settings.getConfiguration(), userClassLoader);
+ final SecretStoreFactory.Context secretStoreContext =
+ TableFactoryUtil.buildSecretStoreFactoryContext(
+ settings.getConfiguration(), userClassLoader);
+ secretStoreFactory.open(secretStoreContext);
+ // TODO (FLINK-38261): pass secret store to catalog manager for
encryption/decryption
+ final SecretStore secretStore =
+ settings.getSecretStore() != null
+ ? settings.getSecretStore()
Review Comment:
I created a new PR for the refactoring:
https://github.com/apache/flink/pull/27531
##########
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/EnvironmentSettings.java:
##########
@@ -154,6 +158,12 @@ public Optional<SqlFactory> getSqlFactory() {
return Optional.ofNullable(sqlFactory);
}
+ @Internal
+ @Nullable
+ public SecretStore getSecretStore() {
Review Comment:
Put in new PR: https://github.com/apache/flink/pull/27531
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
