ldadima commented on code in PR #27508:
URL: https://github.com/apache/flink/pull/27508#discussion_r2766856247
##########
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/JoinITCase.scala:
##########
@@ -623,6 +624,22 @@ class JoinITCase(miniBatch: MiniBatchMode, state:
StateBackendMode, enableAsyncS
assertThat(sink.getRetractResults.sorted).isEqualTo(expected.sorted)
}
+ @TestTemplate
+ def testInnerMultiJoinWithEqualPk(): Unit = {
Review Comment:
Thanks for your review
1 Checked. All passed
<img width="1353" height="161" alt="image"
src="https://github.com/user-attachments/assets/f04af3aa-8a88-46ef-9cdc-958bfc5a551a";
/>
2 I don't understand why we need to add SemanticTest. The problem only
occurs after restoring from a checkpoint and only for HeapStateBackend. Also in
SemanticTest there is MULTI_JOIN_TWO_WAY_INNER_JOIN_WITH_WHERE_IN, which checks
similar sql (uses the same MultiJoinStateViews.JoinKeyContainsUniqueKey). I
suggest modify MultiJoinITCase
([here](https://github.com/apache/flink/pull/27415)) for failingDataSource and
add this case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
