pnowojski commented on code in PR #27505: URL: https://github.com/apache/flink/pull/27505#discussion_r2768953381
########## flink-table/flink-table-runtime/src/test/java/org/apache/flink/table/runtime/operators/aggregate/MiniBatchGroupAggFunctionTest.java: ########## @@ -0,0 +1,208 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.runtime.operators.aggregate; + +import org.apache.flink.streaming.util.KeyedOneInputStreamOperatorTestHarness; +import org.apache.flink.streaming.util.OneInputStreamOperatorTestHarness; +import org.apache.flink.table.data.GenericRowData; +import org.apache.flink.table.data.RowData; +import org.apache.flink.table.runtime.dataview.StateDataViewStore; +import org.apache.flink.table.runtime.generated.AggsHandleFunction; +import org.apache.flink.table.runtime.generated.GeneratedAggsHandleFunction; +import org.apache.flink.table.runtime.generated.GeneratedRecordEqualiser; +import org.apache.flink.table.runtime.generated.RecordEqualiser; +import org.apache.flink.table.runtime.keyselector.RowDataKeySelector; +import org.apache.flink.table.runtime.operators.bundle.KeyedMapBundleOperator; +import org.apache.flink.table.runtime.operators.bundle.trigger.CountBundleTrigger; +import org.apache.flink.table.runtime.util.GenericRowRecordSortComparator; +import org.apache.flink.table.runtime.util.RowDataHarnessAssertor; +import org.apache.flink.table.types.logical.BigIntType; +import org.apache.flink.table.types.logical.LogicalType; +import org.apache.flink.table.types.logical.RowType; +import org.apache.flink.table.types.logical.VarCharType; +import org.apache.flink.table.utils.HandwrittenSelectorUtil; + +import org.junit.jupiter.api.Test; + +import java.util.ArrayList; +import java.util.List; + +import static org.apache.flink.table.runtime.util.StreamRecordUtils.deleteRecord; +import static org.apache.flink.table.runtime.util.StreamRecordUtils.insertRecord; + +/** + * Tests for {@link MiniBatchGroupAggFunction}. + * + * <p>This test covers the scenario where MiniBatchGroupAggFunction.finishBundle() encounters a key + * with only retraction messages and no state. + */ +class MiniBatchGroupAggFunctionTest { + + // Input row: (key: String, value: Long) + private final LogicalType[] inputFieldTypes = + new LogicalType[] {VarCharType.STRING_TYPE, new BigIntType()}; + + private final RowType inputRowType = RowType.of(inputFieldTypes, new String[] {"key", "value"}); + + // Accumulator: (sum: Long) + private final LogicalType[] accTypes = new LogicalType[] {new BigIntType()}; + + // Output row: (key: String, sum: Long) + private final LogicalType[] outputTypes = + new LogicalType[] {VarCharType.STRING_TYPE, new BigIntType()}; + + private final int keyIdx = 0; + private final RowDataKeySelector keySelector = + HandwrittenSelectorUtil.getRowDataSelector(new int[] {keyIdx}, inputFieldTypes); + + private final RowDataHarnessAssertor assertor = + new RowDataHarnessAssertor( + outputTypes, new GenericRowRecordSortComparator(keyIdx, outputTypes[keyIdx])); + + /** Test AggsHandleFunction that sums the value field (index 1). */ + private static class SumAggsHandleFunction implements AggsHandleFunction { Review Comment: Can not you re-use `org.apache.flink.table.runtime.operators.over.SumAggsHandleFunction`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
