balassai commented on code in PR #27514:
URL: https://github.com/apache/flink/pull/27514#discussion_r2771340175
##########
flink-runtime/src/test/java/org/apache/flink/runtime/net/SSLUtilsTest.java:
##########
@@ -392,22 +392,10 @@ void
testSetSSLVersionAndCipherSuitesForSSLServerSocket(String sslProvider) thro
@MethodSource("parameters")
void testCreateSSLEngineFactory(String sslProvider) throws Exception {
Configuration serverConfig =
createInternalSslConfigWithKeyAndTrustStores(sslProvider);
- final String[] sslAlgorithms;
- final String[] expectedSslProtocols;
- if (sslProvider.equalsIgnoreCase("OPENSSL")) {
- // openSSL does not support the same set of cipher algorithms!
Review Comment:
Thanks, it does not support with TLSv1, only TLSv1.2, going to revert this.
https://docs.openssl.org/1.0.2/man1/ciphers/#tls-v12-cipher-suites
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
