rionmonster commented on code in PR #27554:
URL: https://github.com/apache/flink/pull/27554#discussion_r2785921124
##########
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/wmassigners/WatermarkAssignerOperator.java:
##########
@@ -119,6 +138,13 @@ public void open() throws Exception {
getProcessingTimeService().registerTimer(now + timerInterval,
this);
}
+ // Register metrics for null rowtime handling
+ if (rowtimeNullHandling == RowtimeNullHandling.DROP) {
Review Comment:
Minor suggestion/nit: alternatively, we could consider initializing both
counters in open() regardless of the null-handling strategy. That would help
decouple setup and usage and make this a bit more resilient to future changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
