davidradl commented on code in PR #27561:
URL: https://github.com/apache/flink/pull/27561#discussion_r2787520464
##########
flink-models/flink-model-triton/src/main/java/org/apache/flink/model/triton/TritonInferenceModelFunction.java:
##########
@@ -311,20 +414,49 @@ private void handleErrorResponse(
errorMsg.append(" • Consider increasing timeout
configuration\n");
}
- future.completeExceptionally(
- new TritonServerException(errorMsg.toString(),
statusCode));
+ exception = new TritonServerException(errorMsg.toString(),
statusCode);
+ handleFailureWithRetry(rowData, future, attemptNumber, exception);
} else {
// Unexpected status code
errorMsg.append("\n=== Unexpected Status Code ===\n");
errorMsg.append(" • This status code is not standard for
Triton\n");
errorMsg.append(" • Check if proxy/load balancer is involved\n");
- future.completeExceptionally(
- new TritonClientException(errorMsg.toString(),
statusCode));
+ exception = new TritonClientException(errorMsg.toString(),
statusCode);
+ handleFailureWithRetry(rowData, future, attemptNumber, exception);
}
}
+ /**
+ * Parses the configured default value string into RowData collection.
+ *
+ * @return Collection containing single RowData with default value
+ * @throws JsonProcessingException If parsing JSON default value fails
+ */
+ private Collection<RowData> parseDefaultValue() throws
JsonProcessingException {
+ List<RowData> results = new ArrayList<>();
+ String defaultValueStr = getDefaultValue();
+
+ Object deserializedData;
+
+ if (outputType instanceof VarCharType) {
+ // String type - use value directly
+ deserializedData = BinaryStringData.fromString(defaultValueStr);
+ } else if (outputType instanceof ArrayType) {
+ // Array type - parse JSON array
+ JsonNode jsonNode = objectMapper.readTree(defaultValueStr);
Review Comment:
this if body seems the same as the next else body, can we remove it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
