nateab opened a new pull request, #27572:
URL: https://github.com/apache/flink/pull/27572

   ## What is the purpose of the change
   
   Backport of #27505 to `release-2.2`.
   
   This fixes a bug in `MiniBatchGroupAggFunction.finishBundle()` where records 
were being silently dropped when a mini-batch bundle contained a key with only 
retraction messages and no existing accumulator state.
   
   The root cause was using `return` instead of `continue` when `inputRows` 
became empty after filtering out leading retraction messages for a key with no 
state. This caused the method to exit entirely, abandoning processing of all 
remaining keys in the bundle.
   
   ## Brief change log
   
   - Changed `return;` to `continue;` in 
`MiniBatchGroupAggFunction.finishBundle()` so processing continues to the next 
key instead of exiting the entire method
   - Added unit test `MiniBatchGroupAggFunctionTest` that directly verifies the 
fix
   
   ## Verifying this change
   
   This change added tests and can be verified as follows:
   - Added 
`MiniBatchGroupAggFunctionTest.testFinishBundleContinuesAfterEmptyInputRows()` 
which creates a mock bundle with three keys where the first key has only a 
DELETE message (no existing state). The test verifies that keys after the first 
are still processed correctly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to