xintongsong commented on code in PR #525:
URL: https://github.com/apache/flink-agents/pull/525#discussion_r2791225196
##########
python/pyproject.toml:
##########
@@ -55,7 +55,6 @@ dependencies = [
"anthropic>=0.64.0",
"chromadb==1.0.21",
"onnxruntime<1.24.1;python_version<'3.11'",
- "onnxruntime>=1.24.1;python_version>='3.11'",
Review Comment:
Thanks for the nice discussion. Here are my two cents.
1. We should definitely support both x86 and arm on macos
2. IIUC, the two objective constraints that we need to strictly follow:
- onnxruntime 1.24.1 does not support python 3.10
- onnxruntime 1.24.1 does not support x86 on macos
3. There's no strong demand for using onnxruntime 1.24.1+ on python 3.11
Based on these, I think the changes @alnzng proposed in this PR make sense.
WDYT, @wenjin272?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
