rionmonster commented on code in PR #27576:
URL: https://github.com/apache/flink/pull/27576#discussion_r2791264594
##########
flink-metrics/flink-metrics-prometheus/src/main/java/org/apache/flink/metrics/prometheus/PrometheusPushGatewayReporterFactory.java:
##########
@@ -70,17 +72,28 @@ public PrometheusPushGatewayReporter
createMetricReporter(Properties properties)
jobName = configuredJobName + new AbstractID();
}
+ String username = metricConfig.getString(USERNAME.key(), null);
Review Comment:
Minor consistency nit: for consistency, we may want to use `defaultValue()`
instead of `null` here as those would both functionally identical (null) but
would follow the same pattern as the other available configuration options.
For example, `HOST_URL`:
```
String hostUrl = metricConfig.getString(HOST_URL.key(),
HOST_URL.defaultValue());
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
