leonardBang commented on code in PR #4269:
URL: https://github.com/apache/flink-cdc/pull/4269#discussion_r2792183646
##########
flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-iceberg/src/main/java/org/apache/flink/cdc/connectors/iceberg/sink/IcebergDataSinkOptions.java:
##########
@@ -78,4 +78,12 @@ public class IcebergDataSinkOptions {
.defaultValue(-1)
.withDescription(
"The parallelism for file compaction, default
value is -1, which means that compaction parallelism is equal to sink writer
parallelism.");
+
+ @Experimental
+ public static final ConfigOption<String> SINK_JOB_ID_PREFIX =
+ key("sink.job.id.prefix")
Review Comment:
Thanks for your great work @fcfangcc @lvyanquan, I've minor concern about
this config, IIUC, this prefix is used to distinguish the source of writing
stream, and we don't have a job kind called `sink`, we can simply call this as
`job.id.prefix` and the `sink` is part of a flink `job` from the concept's
perspective. Could we adjust this config if possible?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
