davidradl commented on code in PR #27552:
URL: https://github.com/apache/flink/pull/27552#discussion_r2792588528
##########
flink-runtime-web/web-dashboard/src/app/pages/job/overview/watermarks/job-overview-drawer-watermarks.component.ts:
##########
@@ -62,7 +100,27 @@ export class JobOverviewDrawerWatermarksComponent
implements OnInit, OnDestroy {
private readonly cdr: ChangeDetectorRef
) {}
+ private getBrowserTimezone(): string {
+ // Get browser's IANA timezone identifier
+ // This will properly handle DST changes
+ try {
+ const browserTimezone = Intl.DateTimeFormat().resolvedOptions().timeZone;
+
+ // Check if the browser timezone exists in the options list
+ const exists = this.timezoneOptions.some(option => option.value ===
browserTimezone);
+
+ // If browser timezone exists in the list, use it; otherwise default to
UTC
+ return exists ? browserTimezone : 'UTC';
+ } catch (error) {
+ console.error('[getBrowserTimezone] Error getting browser timezone:',
error);
Review Comment:
nit: Maybe expand the error to add - so using UTC.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
