davidradl commented on code in PR #18:
URL:
https://github.com/apache/flink-connector-http/pull/18#discussion_r2801134182
##########
flink-connector-http/src/test/java/org/apache/flink/connector/http/sink/HttpSinkConnectionTest.java:
##########
@@ -267,13 +255,13 @@ public void testServerErrorConnection() throws Exception {
source.sinkTo(httpSink);
env.execute("Http Sink test failed connection");
- assertEquals(1, SendErrorsTestReporterFactory.getCount());
+ assertThat(SendErrorsTestReporterFactory.getCount()).isEqualTo(1);
// TODO: reintroduce along with the retries
// var postedRequests = wireMockServer
// .findAll(postRequestedFor(urlPathEqualTo("/myendpoint")));
- // assertEquals(2, postedRequests.size());
- // assertEquals(postedRequests.get(0).getBodyAsString(),
- // postedRequests.get(1).getBodyAsString());
+ // assertThat(postedRequests).hasSize(2);
Review Comment:
leaving this comment TODO as this change was just around changing the junit
style
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
