rionmonster commented on PR #27609:
URL: https://github.com/apache/flink/pull/27609#issuecomment-3902523323
@featzhang
Thanks for this — it looks like a major quality-of-life improvement!
A large portion of the failing tests appear to be due to duplicate
projection output. You can see this in several existing `flink-table-planner`
tests, which look like the following:
```
Expected:
LogicalProject(a=[$0], b=[$1], c=[$2]), ...
but was:
LogicalProject(select=[a, b, c], a=[$0], b=[$1], c=[$2])
```
After tracing this through, it seems that `RelExplainUtil.explain_()` is
correctly emitting the new projection format provided (e.g. select=[a, b, c]),
but the original attributes are _also_ being rendered via
`Project.explainTerms()` (e.g. a=[$0], b=[$1], c=[$2]), resulting in a
combination of both.
I think we’ll need to account for this duplicate output for the projections
and update the affected test cases accordingly to match the updated logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
