snuyanzin commented on code in PR #27613: URL: https://github.com/apache/flink/pull/27613#discussion_r2809047950
########## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/CodeGeneratorContext.scala: ########## @@ -129,6 +129,9 @@ class CodeGeneratorContext( // string_constant -> reused_term private val reusableStringConstants: mutable.Map[String, String] = mutable.Map[String, String]() + // set of function instance term that will be added only once + private val reusableFunctionTerms: mutable.HashSet[String] = mutable.HashSet[String]() + Review Comment: how can we be sure in this? Can we add a test with custom udf and counter inside checking that it was invoked once? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
