davidradl commented on code in PR #27616:
URL: https://github.com/apache/flink/pull/27616#discussion_r2809759080
##########
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/rules/physical/stream/StreamPhysicalOverAggregateRule.scala:
##########
@@ -83,6 +82,52 @@ class StreamPhysicalOverAggregateRule(config: Config)
extends ConverterRule(conf
outputRowType,
logicWindow)
}
+
+ private def inferOutputRowType2(
Review Comment:
nit: unless there is a concept of a type2, I think we should name this
method more descriptively or if possible have it as overloaded with the same
name. Maybe the caller calls recalculateTypesIfRequired then, calls the
original `OverAggregateUtil.inferOutputRowType(`. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
