ferenc-csaky commented on code in PR #20:
URL:
https://github.com/apache/flink-connector-http/pull/20#discussion_r2810987007
##########
flink-connector-http/pom.xml:
##########
@@ -306,10 +306,61 @@ under the License.
</dependency>
<dependency>
- <groupId>com.github.tomakehurst</groupId>
+ <groupId>org.wiremock</groupId>
<artifactId>wiremock</artifactId>
<version>${wiremock.version}</version>
<scope>test</scope>
+ <exclusions>
Review Comment:
I guess you needed to replicate exclusions here, cause this definition is
not inheriting the one defined in the root POM, which I think is wrong. You
also changed the `groupId` here, but not in the root POM.
Replicating the exclusions here is unnecessary, we just need to defined
this de to inherit the one in the root POM, so I'd match `groupId` in the root
POM, and remove the explicit `version` and all the `exclusions` here.
##########
flink-connector-http/pom.xml:
##########
@@ -306,10 +306,61 @@ under the License.
</dependency>
<dependency>
- <groupId>com.github.tomakehurst</groupId>
+ <groupId>org.wiremock</groupId>
<artifactId>wiremock</artifactId>
<version>${wiremock.version}</version>
<scope>test</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>com.google.guava</groupId>
+ <artifactId>guava</artifactId>
+ </exclusion>
+ <exclusion>
+ <groupId>commons-io</groupId>
+ <artifactId>commons-io</artifactId>
+ </exclusion>
+ <exclusion>
+ <groupId>org.slf4j</groupId>
+ <artifactId>slf4j-api</artifactId>
+ </exclusion>
+ <exclusion>
+ <groupId>net.minidev</groupId>
+ <artifactId>json-smart</artifactId>
+ </exclusion>
+ <exclusion>
+ <groupId>org.apache.commons</groupId>
+ <artifactId>commons-lang3</artifactId>
+ </exclusion>
+ <exclusion>
+ <groupId>org.ow2.asm</groupId>
+ <artifactId>asm</artifactId>
+ </exclusion>
+ <exclusion>
+ <groupId>org.hamcrest</groupId>
+ <artifactId>hamcrest-core</artifactId>
+ </exclusion>
+ <exclusion>
+ <groupId>net.javacrumbs.json-unit</groupId>
+ <artifactId>json-unit-core</artifactId>
+ </exclusion>
+ <exclusion>
+ <groupId>com.networknt</groupId>
+ <artifactId>json-schema-validator</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+
+ <dependency>
+ <groupId>net.javacrumbs.json-unit</groupId>
+ <artifactId>json-unit-core</artifactId>
+ <version>2.40.1</version>
Review Comment:
I see that this is not enforced in this project, so it should not be the
scope of this PR, but in a subsequent change I'd centralize all dep and plugin
versions in the root POM props in alphabetic order, cause it's a lot more human
friendly.
And the same i true for exclusions, cause if we start excluding per-module
it will be a lot more effort top maintain convergence cause it will be possible
that the same dep is included with a different transitive version set.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
