GitHub user uce opened a pull request:

    https://github.com/apache/flink/pull/3152

    [FLINK-5484] [serialization] Revert Chill version update

    This PR reverts the Twitter Chill dependency update. The version updates 
breaks backwards compatability for savepoints which contain user types that 
were serialized with Kryo, because Chills adds new default serializers that 
change the class IDs.
    
    In Flink 1.1 the default next available class ID was X and registered user 
types got IDs assigned starting at X. In Flink 1.2, the newly added serializers 
in Chill got assigned IDs starting at X before the user types are registered, 
which can lead to user types trying to be deserialized with the wrong 
serializer.
    
    I've verified that this with a savepoint (the one that triggered this 
issue) and furthermore added a test that checks that the default registration 
map does not change between versions. Once we have proper serializer 
versioning, that test will become obsolete.
    
    I would like to merge this to: `release-1.1`, `release-1.2`, and `master`.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/uce/flink 5484-kryo_1.2

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/3152.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3152
    
----
commit 55483b71f36b84ac57d03a9b83e0e9d9b9b98eab
Author: Ufuk Celebi <[email protected]>
Date:   2017-01-17T18:10:33Z

    [FLINK-5484] [serialization] Add test for registered Kryo types

commit ebd656310ac9e6323fc7b09632c8aef08f06ba48
Author: Ufuk Celebi <[email protected]>
Date:   2017-01-18T10:27:43Z

    Revert "[FLINK-2608] Updated Twitter Chill version."
    
    This reverts commit 0d3ff88b369fbb1b0a8fb0e8263c9ce0a9da1583.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to