Izeren commented on code in PR #27617:
URL: https://github.com/apache/flink/pull/27617#discussion_r2814095308
##########
flink-core/src/test/java/org/apache/flink/core/fs/FileSystemTest.java:
##########
@@ -115,6 +124,67 @@ void testKnownFSWithoutPluginsAndException() {
}
}
+ private static final String PRIORITY_TEST_SCHEME = "priority-test";
+
+ static Stream<Arguments> prioritySelectionCases() {
+ return Stream.of(
+ Arguments.of(0, 0, DummyFsB.class),
Review Comment:
Code (before my change) results in "last loaded" wins strategy. I wanted my
change to be fully backwards compatible, so added this test.
If iteration order will deterministically change this test would fail (I
doubt we will have many changes in this code coming any time soon). Could you
please elaborate on what do you mean by silently? And why it wouldn't show up
on PR that changes the order?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
