rkhachatryan commented on PR #22931: URL: https://github.com/apache/flink/pull/22931#issuecomment-3917666220
I'm curious, was there any reason why this feature was not implemented "outside" of `CheckpointScheduler`? I mean something like this: 1. `SourceCoordinator` decides if there's backlog and communicates that to `CheckpointCoordinatorDeActivator` 2. `CheckpointCoordinatorDeActivator` chooses an appropriate interval and sets it on `CheckpointScheduler` 3. If it's > 0 then starts scheduling (as it does now) 4. Once backlog is consumed, `SourceCoordinator` communicates that to `CheckpointCoordinatorDeActivator` 5. CheckpointCoordinatorDeActivator` stops the scheduler, updates the interval, and starts it again IMO, that would move much of the complexity out of `CheckpointScheduler` / `CheckpointDecider` and probably avoid race conditions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
