rionmonster commented on PR #27598: URL: https://github.com/apache/flink/pull/27598#issuecomment-3918683341
@DeamonDev The more I think about it, we may be better off reintroducing the previous `TrackableCommitterMetricGroup` (or a similarly named) static class under the `MetricsGroupTestUtils` package, following your earlier approach. That seems preferable to making `InternalSinkCommitterMetricGroup` public (from its current protected-private visibility). Aside from that, everything else looks good to me. I’ll also kick off a separate CI build to see if this — or any other issues — are still lingering. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
