dawidwys commented on code in PR #27602:
URL: https://github.com/apache/flink/pull/27602#discussion_r2832074184
##########
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/sink/WatermarkCompactingSinkMaterializer.java:
##########
@@ -312,7 +311,7 @@ private void bufferRecord(long timestamp, RowData row)
throws Exception {
}
buffer.put(timestamp, records);
- timerService.registerEventTimeTimer(VoidNamespace.INSTANCE, timestamp);
+ timerService.registerEventTimeTimer(VoidNamespace.INSTANCE, timestamp
+ 1);
Review Comment:
I don't see a point in that. When you emit `MAX_VALUE` there won't be any
new records anyhow afterwards. So there will be no records with timestamp
`MAX_VALUE` and we don't care if a timer fires or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
