1996fanrui commented on PR #27624:
URL: https://github.com/apache/flink/pull/27624#issuecomment-3935022883
> In the original version, I fixed it at a lower level as you suggest. But
there, it affects other notification paths besides of Task cleanup - which
probably should **not** tolerate this error.
Thanks for the valuable input! I did not test it, so not sure if the
notification paths is suitable, or they can be changed as well.
> In the current version, we're certain that it's Task cleanup, so the error
can be ignored (if the channel errored already). However, it can be some error
not related to channel.
>
> Maybe the middle ground is to catch it StreamTaskNetworkInput but check
explicitly that it's a `RemoteTransportException`. Something like
>
> ```
> } catch (Exception e) {
> if (hadError &&
> ExceptionUtils.findThrowable(e,
RemoteTransportException.class).isPresent()) {
> ```
>
> WDYT?
The new proposal makes sense to me, it only suppresses the
`RemoteTransportException`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
