Efrat19 commented on code in PR #27638:
URL: https://github.com/apache/flink/pull/27638#discussion_r2837876055
##########
flink-runtime/src/main/java/org/apache/flink/streaming/api/operators/SourceOperator.java:
##########
@@ -781,6 +782,13 @@ public void updateCurrentEffectiveWatermark(long
watermark) {
public void updateCurrentSplitWatermark(String splitId, long watermark) {
WatermarkSampler splitWatermarkSampler =
checkNotNull(sampledSplitWatermarks.get(splitId));
splitWatermarkSampler.addLatest(watermark);
+ if (!currentlyIdleSplits.contains(splitId)) {
+ maybePauseSplit(splitId);
+ }
+ }
+
+ private void maybePauseSplit(String splitId) {
Review Comment:
This method checks if the split watermark is too advanced and if yes calls
`pauseOrResumeSplit` for it, unless already paused.
I am not aware of a "paused watermark" concept, but open to other
suggestions on how to name this method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
