davidradl commented on code in PR #27631:
URL: https://github.com/apache/flink/pull/27631#discussion_r2840979010
##########
flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/writer/AsyncSinkWriter.java:
##########
@@ -353,7 +353,7 @@ private BasicRequestInfo createRequestInfo() {
private void flush() throws InterruptedException {
RequestInfo requestInfo = createRequestInfo();
while (rateLimitingStrategy.shouldBlock(requestInfo)) {
- mailboxExecutor.yield();
Review Comment:
I am curious, is the yield behaviour an explicit contract documented on the
yield method or due to the implementations of yield?
If it is not explicit, we should update the javadoc for the yield method in
the interface.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
