RocMarshal commented on code in PR #27657:
URL: https://github.com/apache/flink/pull/27657#discussion_r2845752740
##########
flink-tests/src/test/java/org/apache/flink/api/connector/source/lib/util/RateLimitedSourceReaderITCase.java:
##########
@@ -44,12 +45,13 @@
import static org.assertj.core.api.Assertions.assertThat;
/** An integration test for rate limiting built into the DataGeneratorSource.
*/
-public class RateLimitedSourceReaderITCase extends TestLogger {
+@ExtendWith(TestLoggerExtension.class)
+public class RateLimitedSourceReaderITCase {
Review Comment:
Could the `public` be deleted ?
##########
flink-tests/src/test/java/org/apache/flink/api/datastream/DataStreamBatchExecutionITCase.java:
##########
@@ -187,7 +183,7 @@ public void batchReduceSingleResultPerKey() throws
Exception {
try (CloseableIterator<Long> sumsIterator = sums.executeAndCollect()) {
List<Long> results = CollectionUtil.iteratorToList(sumsIterator);
- assertThat(results, equalTo(Arrays.asList(30L, 25L)));
+ assertThat(results).isEqualTo(Arrays.asList(30L, 25L));
Review Comment:
--> containsExactlyXXX
##########
flink-tests/src/test/java/org/apache/flink/test/accumulators/AccumulatorErrorITCase.java:
##########
@@ -77,7 +76,7 @@ public void testFaultyAccumulator() throws Exception {
}
@Test
- public void testInvalidTypeAccumulator() throws Exception {
+ public void testInvalidTypeAccumulator() {
Review Comment:
```suggestion
void testInvalidTypeAccumulator() {
```
##########
flink-tests/src/test/java/org/apache/flink/api/datastream/DataStreamCollectTestITCase.java:
##########
@@ -139,8 +136,8 @@ public void testAsyncCollectWithSinkConfigs() {
((CollectSinkFunction<?>)
((CollectSinkOperator<?>)
collectSinkOperatorFactory.getOperator())
.getUserFunction());
- Assert.assertEquals(2,
collectSinkOperatorFactory.getSocketTimeoutMillis());
- Assert.assertEquals(3, collectSinkFunction.getMaxBytesPerBatch());
+ assertEquals(2, collectSinkOperatorFactory.getSocketTimeoutMillis());
+ assertEquals(3, collectSinkFunction.getMaxBytesPerBatch());
Review Comment:
It would be better if use assertThat.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
