snuyanzin commented on code in PR #27674:
URL: https://github.com/apache/flink/pull/27674#discussion_r2853428313
##########
flink-table/flink-table-common/src/main/java/org/apache/flink/types/ColumnList.java:
##########
@@ -46,15 +47,20 @@ public final class ColumnList implements Serializable {
private final List<DataType> dataTypes;
private ColumnList(List<String> names, List<DataType> dataTypes) {
- this.names = Preconditions.checkNotNull(names, "Names must not be
null.");
- this.dataTypes = Preconditions.checkNotNull(dataTypes, "Data types
must be null.");
+ Preconditions.checkNotNull(names, "Names must not be null.");
Review Comment:
should we have a check here that all names are unique?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
