snuyanzin commented on code in PR #27594:
URL: https://github.com/apache/flink/pull/27594#discussion_r2871978580
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/converters/materializedtable/SqlCreateOrAlterMaterializedTableConverter.java:
##########
@@ -105,88 +97,24 @@ private Operation handleAlter(
final ResolvedCatalogMaterializedTable oldTable,
final ConvertContext context,
final ObjectIdentifier identifier) {
- final MergeContext mergeContext =
getMergeContext(sqlCreateOrAlterTable, context);
+ final ResolvedCatalogMaterializedTable newTable =
+ getResolvedCatalogMaterializedTable(
+ sqlCreateOrAlterTable, oldTable.getResolvedSchema(),
context);
- final List<TableChange> tableChanges = buildTableChanges(oldTable,
mergeContext);
- final MaterializedTableChangeHandler.MaterializedTableChangeResult
result =
-
MaterializedTableChangeHandler.buildNewMaterializedTable(oldTable,
tableChanges);
- return new AlterMaterializedTableAsQueryOperation(
- identifier,
- tableChanges,
- oldTable,
- result.getNewMaterializedTable(),
- result.getValidationErrors());
+ return new FullAlterMaterializedTableOperation(oldTable, newTable,
identifier);
}
private Operation handleCreate(
final SqlCreateOrAlterMaterializedTable sqlCreateOrAlterTable,
final ConvertContext context,
final ObjectIdentifier identifier) {
final ResolvedCatalogMaterializedTable resolvedTable =
- getResolvedCatalogMaterializedTable(sqlCreateOrAlterTable,
context);
+ getResolvedCatalogMaterializedTable(
+ sqlCreateOrAlterTable, ResolvedSchema.of(), context);
return new CreateMaterializedTableOperation(identifier, resolvedTable);
}
- private List<TableChange> buildTableChanges(
- final ResolvedCatalogMaterializedTable oldTable, final
MergeContext mergeContext) {
- final List<TableChange> changes = new ArrayList<>();
-
- final ResolvedSchema oldSchema = oldTable.getResolvedSchema();
- final List<Column> newColumns =
- MaterializedTableUtils.validateAndExtractNewColumns(
- oldSchema, mergeContext.getMergedQuerySchema());
-
- newColumns.forEach(column -> changes.add(TableChange.add(column)));
- changes.add(
- TableChange.modifyDefinitionQuery(
- mergeContext.getMergedOriginalQuery(),
- mergeContext.getMergedExpandedQuery()));
-
- return changes;
- }
-
- private CatalogMaterializedTable
buildNewCatalogMaterializedTableFromOldTable(
Review Comment:
just unused
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
