snuyanzin commented on code in PR #27669:
URL: https://github.com/apache/flink/pull/27669#discussion_r2874470916
##########
flink-tests/src/test/java/org/apache/flink/test/misc/MiscellaneousIssuesITCase.java:
##########
@@ -84,12 +84,12 @@ public String map(String value) throws Exception {
env.execute();
fail("this should fail due to null values.");
} catch (JobExecutionException e) {
- assertTrue(findThrowable(e,
NullPointerException.class).isPresent());
+ assertThat(findThrowable(e,
NullPointerException.class)).isPresent();
}
}
Review Comment:
can we replace it with something like
```java
assertThatThrownBy(env::execute)
.isInstanceOf(JobExecutionException.class)
.hasRootCauseInstanceOf(NullPointerException.class);
```
same for other try catches in this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
