GreatEugenius commented on code in PR #557:
URL: https://github.com/apache/flink-agents/pull/557#discussion_r2875661184
##########
dist/flink-1.20/pom.xml:
##########
@@ -159,6 +159,46 @@ under the License.
<createDependencyReducedPom>false</createDependencyReducedPom>
</configuration>
</execution>
+ <!-- Build thin jar for Python wheel (only flink-agents
code) -->
+ <execution>
+ <id>shade-flink-agents-thin</id>
+ <phase>package</phase>
+ <goals>
+ <goal>shade</goal>
+ </goals>
+ <configuration>
+ <shadeTestJar>false</shadeTestJar>
+
<shadedArtifactAttached>false</shadedArtifactAttached>
+
<finalName>${project.artifactId}-${project.version}-thin</finalName>
+ <!-- Only include flink-agents artifacts -->
+ <artifactSet>
+ <includes>
+
<include>org.apache.flink:flink-agents-*</include>
+ </includes>
+ </artifactSet>
+ <filters>
+ <!-- Only include flink-agents classes -->
+ <filter>
+ <artifact>*:*</artifact>
+ <includes>
+
<include>org/apache/flink/agents/**</include>
+ </includes>
+ <!-- Exclude the conflict class for
flink-1.20 -->
+ <excludes>
+
<exclude>org/apache/flink/agents/runtime/operator/OperatorUtils.class</exclude>
Review Comment:
I believe this would exclude OperatorUtils for all versions. For Flink 1.20,
we cannot find OperatorUtils.class. Should we exclude OperatorUtils only in the
runtime module?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
