dylanhz commented on PR #27720: URL: https://github.com/apache/flink/pull/27720#issuecomment-3989088683
> Can we do this without Parser.jj modification? Or first be sure it is merged to Calcite and then port changes here Thanks for the review! BITMAP is not a SQL standard type — it's an extension type specific to analytical systems, so proposing it to Calcite upstream doesn't really make sense. This also shouldn't block Flink from introducing its own extension type. For the Parser.jj concern, would it work if we move the token and type parsing rule into Parser.tdd and parserImpls.ftl? This follows the same pattern used by STRING, BYTES, RAW, etc. The SqlTypeName.java and SqlTypeFamily.java changes would remain as-is. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
