MartijnVisser commented on code in PR #27722:
URL: https://github.com/apache/flink/pull/27722#discussion_r2882408057
##########
tools/ci/compile.sh:
##########
@@ -60,7 +60,7 @@ EXIT_CODE=0
# run with -T1 because our maven output parsers don't support multi-threaded
builds
$MVN clean deploy
-DaltDeploymentRepository=validation_repository::default::file:$MVN_VALIDATION_DIR
-Dflink.convergence.phase=install -Pcheck-convergence \
- -Dmaven.javadoc.skip=true -U -DskipTests "${@}" -T1 | tee
$MVN_CLEAN_COMPILE_OUT
+ -Dmaven.javadoc.skip=true -U -DskipTests
-Dorg.slf4j.simpleLogger.log.org.apache.maven.plugins.shade=DEBUG "${@}" -T1 |
tee $MVN_CLEAN_COMPILE_OUT
Review Comment:
@snuyanzin Confirmed that license checker still works with this change, see
https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=72931&view=logs&j=52b61abe-a3cc-5bde-cc35-1bbe89bb7df5&t=54421a62-0c80-5aad-3319-094ff69180bb&l=308486
```bash
20:26:42,383 INFO org.apache.flink.tools.ci.licensecheck.NoticeFileChecker
[] - Problems were detected for a NOTICE file.
flink-s3-fs-presto:
These issue are legally problematic and MUST be fixed:
Dependency org.apache.commons:commons-lang3:3.19.0 is
not listed.
These issues are mistakes that aren't legally problematic.
They SHOULD be fixed at some point, but we don't have to:
Dependency com.google.guava:guava:30.1.1-jre is not
bundled, but listed.
Dependency org.apache.commons:commons-lang3:3.18.0 is
not bundled, but listed.
Dependency com.google.protobuf:protobuf-java:3.7.1 is
not bundled, but listed.
Dependency software.amazon.ion:ion-java:1.0.2 is not
bundled, but listed.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
