[
https://issues.apache.org/jira/browse/FLINK-3849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15828457#comment-15828457
]
ASF GitHub Bot commented on FLINK-3849:
---------------------------------------
GitHub user tonycox opened a pull request:
https://github.com/apache/flink/pull/3166
[FLINK-3849] [WIP] Add FilterableTableSource interface and Rules for
pushing it
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your
pull request. For more information and/or questions please refer to the [How To
Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful
description of your changes.
- [ ] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira
title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the
JIRA id)
- [ ] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [ ] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis
build has passed
I hove some questions:
1) how to mock `TableScan` and `RelBuilder` in
`#testRewriteRexProgramWithCondition`
2) how to show filter predicate in `#explainTerms`
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tonycox/flink filterableSource
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3166.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3166
----
commit 73448a0425cb53f6b9db0bef5200537e2703a8b0
Author: tonycox <[email protected]>
Date: 2017-01-13T17:08:47Z
[FLINK-5481] Add type extraction from collection
commit 0d7e86f6e37ded863f2b930e2d8ebba9a8fc1c07
Author: tonycox <[email protected]>
Date: 2017-01-17T15:31:15Z
search types by columns
commit 4f38c69c1a307d1910f8c4ad811fb32509248880
Author: tonycox <[email protected]>
Date: 2017-01-11T09:15:49Z
[FLINK-3849] Add FilterableTableSource interface and Rules for pushing it
----
> Add FilterableTableSource interface and translation rule
> --------------------------------------------------------
>
> Key: FLINK-3849
> URL: https://issues.apache.org/jira/browse/FLINK-3849
> Project: Flink
> Issue Type: New Feature
> Components: Table API & SQL
> Reporter: Fabian Hueske
> Assignee: Anton Solovev
>
> Add a {{FilterableTableSource}} interface for {{TableSource}} implementations
> which support filter push-down.
> The interface could look as follows
> {code}
> def trait FilterableTableSource {
> // returns unsupported predicate expression
> def setPredicate(predicate: Expression): Expression
> }
> {code}
> In addition we need Calcite rules to push a predicate (or parts of it) into a
> TableScan that refers to a {{FilterableTableSource}}. We might need to tweak
> the cost model as well to push the optimizer in the right direction.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
