RocMarshal commented on code in PR #27719:
URL: https://github.com/apache/flink/pull/27719#discussion_r2884354424
##########
flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionGraphRestartTest.java:
##########
@@ -105,20 +111,24 @@ void testCancelAllPendingRequestWhileCanceling() throws
Exception {
JobGraph graph = JobGraphTestUtils.streamingJobGraph(sender);
SchedulerBase scheduler =
new DefaultSchedulerBuilder(
- graph, mainThreadExecutor,
EXECUTOR_RESOURCE.getExecutor())
+ graph, mainThreadExecutor,
EXECUTOR_EXTENSION.getExecutor())
.setExecutionSlotAllocatorFactory(
createExecutionSlotAllocatorFactory(slotPool))
.build();
- ExecutionGraph executionGraph = scheduler.getExecutionGraph();
- startScheduling(scheduler);
- offerSlots(slotPool, NUM_TASKS);
+ mainThreadExecutor.execute(
Review Comment:
> @RocMarshal, I ran it locally, and it looks like these lambda invocations
may not even happen before the test exits, so they are likely passing in a
misleading way (not really testing underlying logic)
Hi, @Izeren Thank you very much for your effort on the patch.
I have double-checked the scenarios you pointed out locally based on your
comments and suggestions, and you are absolutely right.
Thank you very much for the reminder and the fix.
I don’t have enough time to follow up on this issue recently. Would you be
willing to take it over?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
