davidradl commented on code in PR #224:
URL:
https://github.com/apache/flink-connector-aws/pull/224#discussion_r2890102276
##########
flink-connector-aws/flink-connector-aws-kinesis-streams/src/main/java/org/apache/flink/connector/kinesis/source/reader/fanout/FanOutKinesisShardSubscription.java:
##########
@@ -161,14 +153,16 @@ public void activateSubscription() {
try {
if (waitForSubscriptionLatch.await(
subscriptionTimeout.toMillis(),
TimeUnit.MILLISECONDS)) {
- LOG.info(
- "Successfully subscribed to shard {} with
starting position {} for consumer {}.",
- shardId,
- startingPosition,
- consumerArn);
- subscriptionActive.set(true);
Review Comment:
why is it safe to remove this subscriptionActive.set(true); should this not
be moved to the `if (error == null) { `block?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
