davidradl commented on code in PR #27734:
URL: https://github.com/apache/flink/pull/27734#discussion_r2890720157
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/utils/DeltaJoinUtil.java:
##########
@@ -270,10 +279,543 @@ public static boolean isJoinTypeSupported(FlinkJoinType
flinkJoinType) {
}
/**
- * get the lookup key from the join keys.
+ * Try to build lookup chain for delta join to do lookup.
+ *
+ * <p>Take the follow join tree as example.
+ *
+ * <pre>{@code
+ * Top
+ * (Set1.a1 = Set2.c1 and Set1.b2 = Set2.d2)
Review Comment:
I am not understanding this picture.
-I see bottom1 (A.a0 = B.b0) and bottom2 as (C.c0 = D.d0)
- what is A.a0 does it relate to Set1 or a1?
so less abstractly
(CustomerSet.name = OrderSet2.customerName and CustomerSet.age =
OrderSet2.customerAge)
what would
* Bottom1 Bottom2
* (A.a0 = B.b0) (C.c0 = D.d0)
Look like as related to the top conditions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
