ldadima commented on code in PR #27508:
URL: https://github.com/apache/flink/pull/27508#discussion_r2893552374


##########
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/join/stream/state/MultiJoinStateViews.java:
##########
@@ -357,7 +370,7 @@ private RowData getStateKey(@Nullable RowData joinKey, 
RowData record) {
                 GenericRowData compositeKey = new GenericRowData(2);
                 compositeKey.setField(0, joinKey);
                 compositeKey.setField(1, record);
-                return compositeKey;
+                return stateKeySerializer.toBinaryRow(compositeKey, 
prohibitReuseRowData);

Review Comment:
   It's the same problem. When we try to take state from HeapBackend  after 
successful restore, we try to find value by GenericRowData, but heap stores 
binary version
   I agree, may  to make a new Jira ticket and create some tests for this case



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to