wenjin272 commented on code in PR #556:
URL: https://github.com/apache/flink-agents/pull/556#discussion_r2893693948
##########
api/src/main/java/org/apache/flink/agents/api/resource/ResourceName.java:
##########
@@ -71,6 +71,12 @@ public static final class ChatModel {
public static final String OPENAI_SETUP =
"org.apache.flink.agents.integrations.chatmodels.openai.OpenAIChatModelSetup";
+ // OpenAI Responses API
+ public static final String OPENAI_RESPONSE_CONNECTION =
+
"org.apache.flink.agents.integrations.chatmodels.openai.OpenAIResponseModelConnection";
+ public static final String OPENAI_RESPONSE_SETUP =
+
"org.apache.flink.agents.integrations.chatmodels.openai.OpenAIResponseModelSetup";
+
Review Comment:
> Should we also rename `OpenAIChatModelConnection` to
`OpenAICompletionsConnection`, `OpenAIChatModelSetup` to
`OpenAICompletionsSetup` for consistency in naming?
Yes, I think we should also change the class names to avoid confusion, as
well as the `resource.py`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
