davidradl commented on code in PR #1044:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/1044#discussion_r2895156999
##########
flink-autoscaler/src/main/java/org/apache/flink/autoscaler/JobVertexScaler.java:
##########
@@ -557,8 +561,10 @@ protected static <KEY, Context extends
JobAutoScalerContext<KEY>> int scale(
// When Mode is MAXIMIZE_UTILISATION , Try to find the
smallest parallelism
// that can satisfy the current consumption rate.
(mode == MAXIMIZE_UTILISATION
- && numKeyGroupsOrPartitions / p
- < numKeyGroupsOrPartitions /
newParallelism)) {
+ && (numKeyGroupsOrPartitions / p
Review Comment:
could we have unit tests for this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
