qinghui-xu commented on code in PR #27744:
URL: https://github.com/apache/flink/pull/27744#discussion_r2904411827
##########
flink-metrics/flink-metrics-prometheus/src/main/java/org/apache/flink/metrics/prometheus/PrometheusPushGatewayReporterOptions.java:
##########
@@ -45,13 +45,6 @@ public class PrometheusPushGatewayReporterOptions {
.defaultValue("")
.withDescription("The job name under which metrics will be
pushed");
- public static final ConfigOption<Boolean> RANDOM_JOB_NAME_SUFFIX =
Review Comment:
Good point. Let me deprecate it in the PR. I'm wondering should I also
change the default value to `false` while keeping it. I'll use this flag as a
switch: if `job` is not suffixed, a "flink_prometheus_push_gateway_reporter_id"
grouping key will be used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
